-
-
Notifications
You must be signed in to change notification settings - Fork 12.7k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
buildStackProject: set GIT_SSL_CAINFO and LANG
- Loading branch information
1 parent
6a04086
commit f4e6738
Showing
1 changed file
with
6 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -27,6 +27,12 @@ stdenv.mkDerivation (args // { | |
LD_LIBRARY_PATH = makeLibraryPath (LD_LIBRARY_PATH ++ buildInputs); | ||
# ^^^ Internally uses `getOutput "lib"` (equiv. to getLib) | ||
|
||
# Non-NixOS git needs cert | ||
GIT_SSL_CAINFO = "${cacert}/etc/ssl/certs/ca-bundle.crt"; | ||
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
domenkozar
Author
Member
|
||
|
||
# Fixes https://github.com/commercialhaskell/stack/issues/2358 | ||
LANG = "en_US.UTF-8"; | ||
|
||
preferLocalBuild = true; | ||
|
||
configurePhase = args.configurePhase or '' | ||
|
1 comment
on commit f4e6738
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's fixed in master :)
@domenkozar, Is this really needed ? We spent a lot of time to make these fixes useless, especially on non-nixos. This kind of hacks triggers a rebuild the produced derivations for every change to cacert. git in nixpkgs supports "SSL_CERT_FILE", which is set by the nix env setup script on non-nixos. (wmertens@272f2c3).
TL; DR; There is no reason to do this, it should work and issues should at be reported for further investigation.