Skip to content

Commit

Permalink
buildStackProject: set GIT_SSL_CAINFO and LANG
Browse files Browse the repository at this point in the history
  • Loading branch information
domenkozar committed Feb 1, 2017
1 parent 6a04086 commit f4e6738
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions pkgs/development/haskell-modules/generic-stack-builder.nix
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,12 @@ stdenv.mkDerivation (args // {
LD_LIBRARY_PATH = makeLibraryPath (LD_LIBRARY_PATH ++ buildInputs);
# ^^^ Internally uses `getOutput "lib"` (equiv. to getLib)

# Non-NixOS git needs cert
GIT_SSL_CAINFO = "${cacert}/etc/ssl/certs/ca-bundle.crt";

This comment has been minimized.

Copy link
@layus

layus Feb 5, 2017

Member

@domenkozar, Is this really needed ? We spent a lot of time to make these fixes useless, especially on non-nixos. This kind of hacks triggers a rebuild the produced derivations for every change to cacert. git in nixpkgs supports "SSL_CERT_FILE", which is set by the nix env setup script on non-nixos. (wmertens@272f2c3).

TL; DR; There is no reason to do this, it should work and issues should at be reported for further investigation.

This comment has been minimized.

Copy link
@domenkozar

domenkozar Feb 5, 2017

Author Member

I saw people having issues on macos, probably since now Nix sets prefix variable with NIX_

This comment has been minimized.

Copy link
@layus

layus Feb 5, 2017

Member

Yes, and there is an open issue about this, where edolstra kicked in: NixOS/nix#921

This comment has been minimized.

Copy link
@domenkozar

domenkozar Feb 6, 2017

Author Member

We can use the upstream Nix solution once new Nix is out :)


# Fixes https://github.com/commercialhaskell/stack/issues/2358
LANG = "en_US.UTF-8";

preferLocalBuild = true;

configurePhase = args.configurePhase or ''
Expand Down

1 comment on commit f4e6738

@domenkozar
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's fixed in master :)

Please sign in to comment.