spark: 1.6.0 -> 2.1.0 #22505
Merged
spark: 1.6.0 -> 2.1.0 #22505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tested in linux with: nix-env -f . -i spark-1.6.0 nix-env -f . -i spark cc @thoughtpolice @offlinehacker
|
@facundominguez, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edwtjo, @mboes and @dezgeg to be potential reviewers. |
Mic92
reviewed
Feb 6, 2017
| @@ -5931,7 +5931,9 @@ with pkgs; | |||
|
|
|||
| self = callPackage_i686 ../development/interpreters/self { }; | |||
|
|
|||
| spark = callPackage ../applications/networking/cluster/spark { }; | |||
| spark = spark_21; | |||
| spark_16 = callPackage ../applications/networking/cluster/spark { version = "1.6.0"; }; | |||
There was a problem hiding this comment.
This should be probably updated to the latest version of the 1.x series (1.6.3).
There was a problem hiding this comment.
@facundominguez ping re updating to latest version
There was a problem hiding this comment.
I don't use 1.6.3. But I'm fine if someone wants to upgrade it.
There was a problem hiding this comment.
I guess we can do that some other time, then
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested in linux with:
nix-env -f . -i spark-1.6.0
nix-env -f . -i spark
cc @thoughtpolice @offlinehacker
Motivation for this change
Have nixpkgs provide a newer version of Spark.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)