Add dafny; fixup Boogie #22507
Merged
Add dafny; fixup Boogie #22507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rycee
reviewed
Feb 6, 2017
| version = "2017-01-03"; | ||
| name = "${baseName}-unstable-${version}"; |
pSub
reviewed
Feb 7, 2017
pkgs/top-level/dotnet-packages.nix
Outdated
| ''; | ||
|
|
||
| meta = { | ||
| description = "A programming language with built-in specification constructs."; |
There was a problem hiding this comment.
Descriptions should not end with a period.
pSub
reviewed
Feb 7, 2017
pkgs/top-level/dotnet-packages.nix
Outdated
|
|
||
| meta = { | ||
| description = "A programming language with built-in specification constructs."; | ||
| homepage = "http://research.microsoft.com/dafny"; |
There was a problem hiding this comment.
Nitpick: You don't need quotes around Urls.
There was a problem hiding this comment.
Unless it is a merge-blocking issue for you, I am going to leave this as-is. There is nothing saying that urls should not be quoted in the CONTRIBUTING.md. And nothing in the nix manual about urls as language values, only paths.
|
Fixed according to reviews, and removed the usage of 'lib' that made travis fail. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for the change
Introduce dafny, which uses Boogie.
And fix Boogie, because the last edit (changing the baseName) right before merge (#22400) broke it.
Also propote boogie and dafny as toplevel packages, because they both have toplevel standalone executables corresponding to their names.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)/cc @obadz ('coz it's dotnet), @taktoa ('coz I changed Boogie), @pSub ('coz he approved the changes to Boogie) and @rycee ('coz he merged Boogie)