Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

emacs24macport: remove #22508

Merged
merged 1 commit into from Mar 18, 2017
Merged

Conversation

matthewbauer
Copy link
Member

Motivation for this change

This removes emacs24macport to match the main emacs (which removes emacs24 ~4 months ago.)

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@LnL7
Copy link
Member

LnL7 commented Feb 6, 2017

I don't see a issue/pr about the removal of v24, was there a discussion about it?

@matthewbauer
Copy link
Member Author

Here's the commit; 01e44ac

@LnL7
Copy link
Member

LnL7 commented Feb 7, 2017

I expected that there would be some people that still want the old version. Note that emacs24 still exists in the release, I expect there's a group of people that will only notice that change when they upgrade to 17.03

@joachifm
Copy link
Contributor

Yay or nay on this?

@LnL7 LnL7 merged commit a48df6f into NixOS:master Mar 18, 2017
@matthewbauer matthewbauer deleted the remove-emacs24macport branch February 22, 2019 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants