Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix window.sessionStorage being not accessible in local paths #3957

Merged

Conversation

Sija
Copy link
Contributor

@Sija Sija commented Jan 30, 2017

This PR fixes error thrown (Chrome 56, macOS) when accessing docs through local file:/// paths:

Uncaught DOMException: Failed to read the 'sessionStorage' property from 'Window': Access is denied for this document.

@Sija Sija force-pushed the fix-local-sessionstorage-error branch from b747f11 to 7299a60 Compare January 31, 2017 01:29
@Sija
Copy link
Contributor Author

Sija commented Feb 8, 2017

Could we have this merged? Without it, browsing docs locally is PITA ;)

@matiasgarciaisaia
Copy link
Member

@Sija I'm using Chrome Version 56.0.2924.87 (64-bit) on macOS 10.12.3, and can't repro the sessionStorage error.

$ git rev-parse HEAD
13d566b9cdea62b2077aa3af06483237524fadf6
$ make clean doc
Using /usr/local/bin/llvm-config-3.6 [version=3.6.2]
rm -rf .build
rm -rf ./doc
rm -rf src/llvm/ext/llvm_ext.o
rm -rf src/ext/sigfault.o src/ext/libcrystal.a
./bin/crystal doc src/docs_main.cr
$ open doc/index.html

Do you have to perform any specific action for the error to trigger?

@Sija
Copy link
Contributor Author

Sija commented Feb 8, 2017

@matiasgarciaisaia matiasgarciaisaia merged commit b0b4497 into crystal-lang:master Feb 8, 2017
@matiasgarciaisaia
Copy link
Member

I could confirm both the bug and the solution - thanks for that! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants