Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kbd: 2.0.3 -> 2.0.4 #22793

Closed
wants to merge 1 commit into from
Closed

kbd: 2.0.3 -> 2.0.4 #22793

wants to merge 1 commit into from

Conversation

rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented Feb 14, 2017 •
edited

Motivation for this change

The unicode_{start,stop} scripts fail due to a hardcoded path.
I patched that and also updated the package.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using (nope, it's a mass rebuild)
  • Tested execution of all binary files
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@rnhmjoj, thanks for your PR! By analyzing the history of the files in this pull request, we identified @abbradar, @edolstra and @wkennington to be potential reviewers.

@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Feb 28, 2017

bump

matthiasbeyer
matthiasbeyer requested changes Mar 5, 2017
View reviewed changes
pkgs/os-specific/linux/kbd/default.nix

stdenv.mkDerivation rec {
name = "kbd-${version}";
version = "2.0.3";
version = "2.0.4";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The hash didn't change with the package update? I doubt that! 😄

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops

@grahamc
Copy link
Member

grahamc commented Mar 6, 2017

Applied in 0577020929

@grahamc grahamc closed this Mar 6, 2017
@grahamc
Copy link
Member

grahamc commented Mar 6, 2017

Thank you!

@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Jul 7, 2017

What happened to this change?

@rnhmjoj rnhmjoj mentioned this pull request Jul 9, 2017
Closed
8 tasks
@therealpxc
Copy link
Contributor

It looks like these changes are not in fact present in master. @matthiasbeyer @grahamc can we reopen this? It includes fixes for a couple scripts which are currently broken (see the referencing pull request above).

@matthiasbeyer
Copy link
Contributor

I have no rights to reopen this.

@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Jul 9, 2017

I can make a new one. What is 0577020929 anyway?

@therealpxc
Copy link
Contributor

Did you ever make the new PR? I'd like to see your changes merged. I'm tired of everything wanting to rebuild from source! :-)

@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Jul 11, 2017

I was waiting from @grahamc to reply but I guess I'll go on.

@rnhmjoj rnhmjoj mentioned this pull request Jul 11, 2017
Merged
7 tasks
@rnhmjoj rnhmjoj deleted the kbd branch September 12, 2017 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthiasbeyer matthiasbeyer matthiasbeyer requested changes

Assignees
No one assigned
Labels
8.has: package (update)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@rnhmjoj @mention-bot @grahamc @therealpxc @matthiasbeyer @pSub