Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
Don't check file readability in port diagnose
Not all files installed by ports should be readable.
  • Loading branch information
jmroot committed Feb 14, 2017
1 parent 103d6f6 commit 738b213
Showing 1 changed file with 4 additions and 8 deletions.
12 changes: 4 additions & 8 deletions src/macports1.0/diagnose.tcl
Expand Up @@ -408,17 +408,13 @@ namespace eval diagnose {
success_fail 0
}
ui_warn "couldn't find file '$file' for port '$name'. Please deactivate and reactivate the port to fix this issue."
} elseif {![file readable $file]} {
if {$fancyOutput} {
$progress intermission
} else {
success_fail 0
}

ui_warn "'$file' installed by port '$name' is currently not readable. Please try again. If this problem persists, please contact the mailing list."
} elseif {!$fancyOutput} {
success_fail 1
}
# TODO: check permissions against those in the port image.
# Can't just check for readability because some files
# (and/or their parent directories) should not be readable
# by normal users for various reasons.

incr currentFile
}
Expand Down

0 comments on commit 738b213

Please sign in to comment.