Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
Port diagnose file check fix
Don't report failure before checking whether a port's apparently
missing file is actually a link.

Fixes: https://trac.macports.org/ticket/53490
  • Loading branch information
jmroot committed Feb 14, 2017
1 parent 741a77b commit 103d6f6
Showing 1 changed file with 2 additions and 5 deletions.
7 changes: 2 additions & 5 deletions src/macports1.0/diagnose.tcl
Expand Up @@ -401,16 +401,13 @@ namespace eval diagnose {
output "file '$file' on disk"
}

if {![file exists $file]} {
if {[catch {file type $file}]} {
if {$fancyOutput} {
$progress intermission
} else {
success_fail 0
}

if {[catch {file lstat $file _}]} {
ui_warn "couldn't find file '$file' for port '$name'. Please deactivate and reactivate the port to fix this issue."
}
ui_warn "couldn't find file '$file' for port '$name'. Please deactivate and reactivate the port to fix this issue."
} elseif {![file readable $file]} {
if {$fancyOutput} {
$progress intermission
Expand Down

0 comments on commit 103d6f6

Please sign in to comment.