Merge pull request #1854 from metacpan/leo/no_cache_account

Leo/no cache account
metacpan · Feb 22, 2017 · 63fcda1 · 63fcda1
2 parents d021750 + 1be21de
commit 63fcda1
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 5 deletions.
diff --git a/lib/MetaCPAN/Web/Controller/Account.pm b/lib/MetaCPAN/Web/Controller/Account.pm
@@ -9,9 +9,7 @@ BEGIN { extends 'MetaCPAN::Web::Controller' }
 sub auto : Private {
     my ( $self, $c ) = @_;
 
-    # Keep everything here as specific to the user
-    # this is for proxies
-    $c->res->header( Vary => 'Cookie' );
+    $c->cdn_never_cache(1);
 
     if ( my $token = $c->token ) {
         $c->authenticate( { token => $token } );

diff --git a/lib/MetaCPAN/Web/Controller/Login.pm b/lib/MetaCPAN/Web/Controller/Login.pm
@@ -7,6 +7,10 @@ BEGIN { extends 'MetaCPAN::Web::Controller' }
 
 sub index : Path : Args(0) {
     my ( $self, $c ) = @_;
+
+    # Never cache at CDN
+    $c->cdn_never_cache(1);
+
     if ( my $code = $c->req->parameters->{code} ) {
         my $data = $c->model('API')->request(
             '/oauth2/access_token',
@@ -29,6 +33,10 @@ sub index : Path : Args(0) {
 
 sub openid : Local : Args(0) {
     my ( $self, $c ) = @_;
+
+    # Never cache at CDN
+    $c->cdn_never_cache(1);
+
     $c->stash( { template => 'account/openid-login.html' } );
 }
 

diff --git a/t/controller/account.t b/t/controller/account.t
@@ -36,8 +36,9 @@ test_psgi app, sub {
             'GET /account/profile without token'
         );
         is( $res->code, 403, '... and the user cannot get in' );
-        is( $res->header('Vary'),
-            'Cookie', '... and the Vary header for proxies is there' );
+        is( $res->header('Cache-Control'),
+            'private',
+            '... and the private Cache-Control header for proxies is there' );
         is( $authenticate_args, undef,
             '... and we did not try to authenticate' );