Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kbfs: 1.0.2 -> 20170209.d1db463 #22601

Merged
merged 1 commit into from Feb 17, 2017
Merged

kbfs: 1.0.2 -> 20170209.d1db463 #22601

merged 1 commit into from Feb 17, 2017

Conversation

SuprDewd
Copy link
Contributor

@SuprDewd SuprDewd commented Feb 9, 2017

Motivation for this change

kbfs is out of date.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

I'm bumping keybase's version simultaneously in #22600. Both programs seem to be actively developed over at Keybase, but it seems that they've stopped making formal releases for keybase, and there were never any formal releases for kbfs. Instead they seem to be something like a rolling release (see https://s3.amazonaws.com/prerelease.keybase.io/linux_binaries/deb/index.html). I picked the commits for keybase/kbfs based on (at the time of writing this) newest entry in that list.

This also fixes some warnings that were being generated due to a slight mismatch between the current versions (in nixpkgs) of keybase and kbfs. See #22375.

@mention-bot
Copy link

@SuprDewd, thanks for your PR! By analyzing the history of the files in this pull request, we identified @bennofs and @aristidb to be potential reviewers.

@globin globin merged commit 8561af2 into NixOS:master Feb 17, 2017
@SuprDewd SuprDewd deleted the update-kbfs branch February 17, 2017 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants