Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pypy: enable dbm support in db dependency #22611

Merged
merged 1 commit into from
Feb 10, 2017
Merged

pypy: enable dbm support in db dependency #22611

merged 1 commit into from
Feb 10, 2017

Conversation

bendlas
Copy link
Contributor

@bendlas bendlas commented Feb 10, 2017

fixes test breakage introduced by #21049 dca3a4e

cc @LnL7

Things done
  • Built on platform(s)
    • NixOS
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@LnL7
Copy link
Member

LnL7 commented Feb 10, 2017

Do you have any idea if that's actually used? This is a legacy interface and will be break with clang>=3.8

@bendlas
Copy link
Contributor Author

bendlas commented Feb 10, 2017

I'm not using it, I'm just interested in our test suites not breaking:
https://bitbucket.org/pypy/pypy/src/fef27077c28608a3010436351821c29686053808/lib-python/2.7/test/test_dbm.py

I suggest you take that question up with pypy folks, or deactivate test_dbm under clang if need be.

@FRidh FRidh merged commit a323b84 into NixOS:master Feb 10, 2017
@FRidh
Copy link
Member

FRidh commented Feb 10, 2017

thanks!

@bendlas bendlas deleted the fix-pypy branch October 22, 2023 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LnL7 LnL7 LnL7 approved these changes

Assignees
No one assigned
Labels
6.topic: python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bendlas @LnL7 @FRidh @domenkozar