add sort_by macro method #3947
add sort_by macro method #3947
Conversation
There was a problem hiding this comment.
A documentation placeholder should be added at https://github.com/crystal-lang/crystal/blob/master/src/compiler/crystal/macros.cr#L543 .
I'm curious, which scenario forced you sort in macros?
repomaa
force-pushed
the
sort_by_macro_method
branch
from
3fdd401
to
c14033f
Compare
|
@bcardiff done :) Sorry I forgot about that. I was writing a kind of model interface similar to json mapping and was building an initializer that would take arguments from the mapping named tuple. There i needed to sort the arguments by nilable so that args that are mandatory are leftmost. There are other ways of doing it of course but i was confused that ArrayLiteral didn't have a sort_by method so i thought it would be nice to have. |
repomaa
force-pushed
the
sort_by_macro_method
branch
from
c14033f
to
ae7b8da
Compare
|
@jreinert Could you rebase on master? |
repomaa
force-pushed
the
sort_by_macro_method
branch
from
ae7b8da
to
63d7e5f
Compare
|
@straight-shoota: done! |
|
@RX14 @straight-shoota: ping |
{{ ["abc", "a", "ab"].sort_by { |string| string.size } }}