Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

musl: build musl-gcc #22212

Merged
merged 1 commit into from Jan 27, 2017
Merged

musl: build musl-gcc #22212

merged 1 commit into from Jan 27, 2017

Conversation

rasendubi
Copy link
Member

The build of the wrapper was disabled in 93e44be (#21023) and is not
related to the CVE itself. (See comments in the mentioned PR.)

Motivation for this change

See discussion in #21023.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

/cc @dtzWill @apatil

The build of the wrapper was disabled in 93e44be (NixOS#21023) and is not
related to the CVE itself. (See comments in the mentioned PR.)
@mention-bot
Copy link

@rasendubi, thanks for your PR! By analyzing the history of the files in this pull request, we identified @dtzWill, @thoughtpolice and @wkennington to be potential reviewers.

@globin globin merged commit 264d42b into NixOS:master Jan 27, 2017
@apatil
Copy link

apatil commented Jan 27, 2017

Thanks, @rasendubi!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants