-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nginx: Format the config file #22209
Conversation
@Baughn, thanks for your PR! By analyzing the history of the files in this pull request, we identified @wlhlm, @globin and @domenkozar to be potential reviewers. |
Example output: http://sprunge.us/WKCc |
Nice! What about removing some blank lines, like |
I feel like that should be done in the formatter, not with sed scripts. I like my config files to have some blank lines, and think the current output is probably better than removing all of them. But in reality, I'm unlikely to write any code to fix that. The config file is readable now. |
You are probably right here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As NixOS/nix#580 is staled, this is a nice compromise.
What still needs doing before this can be merged? |
perhaps a confirmation from @globin |
I haven't had the time to test this and won't have until the weekend, but the code looks good so if anyone confirms he has tested this I'd be very happy to merge :) |
I've tested it, of course... guess that doesn't count. :P |
I've tested this too and already use on my servers |
Motivation for this change
This makes nginx.conf human-readable.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandbox
innix.conf
on non-NixOS)
nix-shell -p nox --run "nox-review wip"
./result/bin/
)