Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zulu: Add home #22187

Merged
merged 1 commit into from Jan 27, 2017
Merged

zulu: Add home #22187

merged 1 commit into from Jan 27, 2017

Conversation

NeQuissimus
Copy link
Member

Motivation for this change

In order to function with some JDK-dependent packages (such as sbt), the Azul Zulu package needs a home variable

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@NeQuissimus NeQuissimus merged commit 772bb72 into NixOS:master Jan 27, 2017
@NeQuissimus NeQuissimus deleted the zulu_home branch January 27, 2017 00:48
grahamc
grahamc reviewed Jan 27, 2017
View reviewed changes
target/.history
@@ -0,0 +1 @@
exit
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed it in d7756e9

NeQuissimus
NeQuissimus commented Jan 27, 2017
View reviewed changes
Copy link
Member Author

@NeQuissimus NeQuissimus left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wtf happened here XD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grahamc grahamc grahamc left review comments

Assignees
No one assigned
Labels
8.has: package (update)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@NeQuissimus @grahamc