Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tips for resolving https issues in containers #22183

Closed
wants to merge 2 commits into from

Conversation

inanna-malick
Copy link
Contributor

@inanna-malick inanna-malick commented Jan 26, 2017

I ran into some issues making HTTPS requests from a container built with buildImage. I've added notes with tips for resolving similar issues.

Motivation for this change

Reduce frustration for new users of buildImage by providing advice for fixing common errors

Things done

I'm not sure what steps I should take for a documentation-only change, please let me know if I can add/do anything to improve this PR.

I ran into some issues making HTTPS requests from a container built with buildImage. I've added notes with tips for resolving similar issues.
@mention-bot
Copy link

@pkinsky, thanks for your PR! By analyzing the history of the files in this pull request, we identified @Profpatsch, @lethalman and @abbradar to be potential reviewers.

@k0001
Copy link
Contributor

k0001 commented Jan 26, 2017

I've been bitten by this, so I'll appreciate a comment about this basic issue in the manual. Thanks!

But I'd recommend going the other way around and do a recommendation based on the features these packages provide, and not on possible errors. For example, something like this:

If this container is expected to do any network interaction, it's likely that cacert and iana_etc will need to be mentioned here, as they provide CA certificates and the list of known network protocols often needed for this.

@inanna-malick
Copy link
Contributor Author

@k0001 good point. I was putting the note at the end of the section because the problem will probably only occur when the docker container is built from scratch (with no base image to provide basic networking utils).

@grahamc
Copy link
Member

grahamc commented Feb 21, 2017

Merging because it is better than what we've got. I'd love a PR improving it.

@grahamc
Copy link
Member

grahamc commented Feb 21, 2017

Merged in b14dd0e.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants