Add --reset-gateware #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Don't merge until we have tested! |
|
@stefanor Can you give this a test? |
stefanor
reviewed
Feb 20, 2017
hdmi2usb/modeswitch/cli.py
Outdated
| @@ -110,6 +110,9 @@ def args_parser(board, mode): | |||
| parser.add_argument( | |||
| '--flash-gateware', | |||
| help='Flash gateware onto the SPI flash which the FPGA boots from.') | |||
| parser.add_argument( | |||
| '--reset-gateware', | |||
| help='Reset gateware currently running on the FPGA.') | |||
There was a problem hiding this comment.
Missing a action='store_true'
stefanor
reviewed
Feb 20, 2017
hdmi2usb/modeswitch/boards.py
Outdated
| assert board.state == "jtag", board | ||
| assert not board.dev.inuse() | ||
| assert board.type in OPENOCD_MAPPING | ||
| return _openocd_script(board, script, verbose) |
There was a problem hiding this comment.
Missing location argument. (or verbose=verbose)
There was a problem hiding this comment.
Err, no, I lie, that's the other helper.
stefanor
reviewed
Feb 21, 2017
hdmi2usb/modeswitch/boards.py
Outdated
| cmdline, | ||
| stdout=subprocess.PIPE, | ||
| stderr=subprocess.STDOUT, | ||
| encoding='utf-8') |
There was a problem hiding this comment.
encoding is a Python 3.6 feature. I don't think you can rely on that, yet.
stefanor
reviewed
Feb 21, 2017
hdmi2usb/modeswitch/boards.py
Outdated
| class OpenOCDError(subprocess.CalledProcessError): | ||
| def __init__(self, msg, returncode, cmd, output): | ||
| subprocess.CalledProcessError.__init__( | ||
| returncode, cmd, output) |
There was a problem hiding this comment.
Missing either a super or self argument.
|
Doesn't seem to work on the opsis, yet. |
mithro
force-pushed
the
reset-gateware
branch
from
2f4f5de
to
6b81368
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.