Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

munin service: listen on IPv6 loopback as well #23012

Merged
merged 1 commit into from
Feb 20, 2017

Conversation

florianjacob
Copy link
Contributor

@florianjacob florianjacob commented Feb 20, 2017

Motivation for this change

The usual and recommended telnet localhost 4949 to check manually whether munin is set up correctly doesn't work on IPv6 enabled systems, but telnet 127.0.0.1 4949 works.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@florianjacob, thanks for your PR! By analyzing the history of the files in this pull request, we identified @domenkozar, @edolstra and @bjornfor to be potential reviewers.

@fpletz fpletz changed the title mumin service: listen on IPv6 loopback as well munin service: listen on IPv6 loopback as well Feb 20, 2017
@fpletz fpletz merged commit c23c2c5 into NixOS:master Feb 20, 2017
@fpletz
Copy link
Member

fpletz commented Feb 20, 2017

Squashed and fixed typo in the commit message. Thanks!

@florianjacob
Copy link
Contributor Author

Thanks! Did watch too mutch mumims as a child, I guess. 😆

@florianjacob florianjacob deleted the munin-ipv6 branch February 20, 2017 08:56
bjornfor pushed a commit that referenced this pull request Mar 22, 2017
munin service: listen on IPv6 loopback as well
(cherry picked from commit c23c2c5)
adrianpk added a commit to adrianpk/nixpkgs that referenced this pull request May 31, 2024
munin service: listen on IPv6 loopback as well
(cherry picked from commit c23c2c5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants