Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fish: 2.3.1 -> 2.5.0 #22447

Merged
merged 1 commit into from
Feb 5, 2017
Merged

fish: 2.3.1 -> 2.5.0 #22447

merged 1 commit into from
Feb 5, 2017

Conversation

rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented Feb 4, 2017

Things done
  • Tested using sandboxing
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

I briefly tested the shell with my setup and I couldn't find any obvious issue but there probably are a few things to patch/update. I would be best if someone else tested this.

@mention-bot
Copy link

@rnhmjoj, thanks for your PR! By analyzing the history of the files in this pull request, we identified @kragniz, @ocharles and @bjornfor to be potential reviewers.

@joachifm
Copy link
Contributor

joachifm commented Feb 5, 2017

Works for me. Are there any particular changelog items we should be concerned about?

@vcunat
Copy link
Member

vcunat commented Feb 5, 2017

I read the NEWS of all intermediate releases and saw nothing suspicious. I've been using it a little for a couple hours now. All seems OK so far.

@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Feb 5, 2017

@joachifm No, nothing in particular just a big changelog.

@joachifm joachifm merged commit 8012ead into NixOS:master Feb 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants