wuzz: init at 2017-02-05 #22464
Closed
wuzz: init at 2017-02-05 #22464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joachifm
requested changes
Feb 5, 2017
|
|
||
| buildGoPackage rec { | ||
| name = "wuzz"; | ||
| version = "89bebba7a4a00c52e97d411a3e82660189adc4ff"; |
There was a problem hiding this comment.
Git revisions are invalid versions; please use the commit date in ISO 8601 format.
| @@ -0,0 +1,25 @@ | |||
| { stdenv, lib, pkgconfig, buildGoPackage, fetchFromGitHub }: | |||
|
@joachifm Thank you for the review. I have updated the pull request as per your suggestions. |
joachifm
reviewed
Feb 6, 2017
| { stdenv, lib, buildGoPackage, fetchFromGitHub }: | ||
|
|
||
| buildGoPackage rec { | ||
| name = "wuzz"; |
There was a problem hiding this comment.
The version must be embedded in the name, as in wuzz-${version}. The version attribute is not special; version strings are actually extracted from name using parseDrvName.
It's still needed by KDE4. It was there, just unreferenced from all-packages.
|
@pradeepchhetri you can also force-push the PR branch to fixup such issues |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)