ansicolor: init at 0.2.4 #22462
Merged
ansicolor: init at 0.2.4 #22462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rasendubi
reviewed
Feb 5, 2017
| name = "ansicolor-${version}"; | ||
| version = "0.2.4"; | ||
|
|
||
| src = pkgs.fetchurl{ |
There was a problem hiding this comment.
Better to replace with fetchFromGitHub.
fetchFromGitHub {
owner = "numerodix";
repo = "ansicolor";
rev = version;
sha256 = "...";
}Also, the package is available on pypi, so it might be preferred.
There was a problem hiding this comment.
@rasendubi: I changed to pypi. Interestingly, there are no tests in the pypi package of ansicolor. Therefore I bypassed the test problem. I've verified that the library still works by running its demos using
nix-shell -I nixpkgs=. --pure -p pythonPackages.ansicolor --command "python -m ansicolor.demos --color"
pkgs/top-level/python-packages.nix
Outdated
| meta = { | ||
| homepage = "https://github.com/numerodix/ansicolor/"; | ||
| description = "A library to produce ansi color output and colored highlighting and diffing"; | ||
| license = "apache"; |
There was a problem hiding this comment.
licenses.asl20 is Apache License 2.0.
rasendubi
approved these changes
Feb 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
New library, not previously in nixpkgs
Needed dependency for vim-vint, which I'll post a PR for after this one goes through. I have verified that vim-vint, which depends on ansicolor, works on my local computer.
The tests for ansicolor do not work in the nix installer. I'm not sure how to fix it and I didn't get a response on the IRC channel. Hoping someone here can help me or point me to the right direction. Otherwise, seems like a lot pythonpackages in nixpkgs suppress tests anyway?Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)