masscan: init at 2016-11-03 #22438
masscan: init at 2016-11-03 #22438
Conversation
| cp data/exclude.conf $out/etc/masscan | ||
| cp -t $out/share/doc/masscan doc/algorithm.js doc/howto-afl.md doc/bot.hml | ||
| cp doc/masscan.8 $out/share/man/man8/masscan.8 | ||
| cp LICENSE $out/share/licenses/masscan/LICENSE |
There was a problem hiding this comment.
There is a minor indentation issue here, but looks good to me other than this.
|
|
||
| stdenv.mkDerivation rec { | ||
| name = "masscan-${version}"; | ||
| version = "2017-02-04"; |
There was a problem hiding this comment.
This should be the date of the git commit you're packaging, in this case 2016-11-03.
Also, is there a specific reason to package the master branch instead of a release?
There was a problem hiding this comment.
The last release is 3 years old and in the meantime many bugfixes and patches have been committed.
|
Maybe the description should invite the user to read carefully the doc/README before running this to prevent one's public IP getting blacklisted somehow. |
|
Also what to do about darwin? It's a supported platform but the build fails. |
|
@rnhmjoj the error message says it fails to find |
rnhmjoj
force-pushed
the
masscan
branch
2 times, most recently
from
99e92c6
to
65f4f87
Compare
|
Now it can't find libpcap references. |
|
This builds fine for me on NixOS. Restarted travis. |
|
Yeah, the problem is darwin. At this point I should just disable it. |
|
I disabled darwin since no one could figure this out. |
|
@c0bw3b you can get yourself banned with usual nmap, and I think this massscan tool is useful even on a medium-size LAN… |
Things done
./result/bin/)