Fix 'date' to id3 mapping #618
Conversation
According to the [date docs](https://musicbrainz.org/doc/Release/Date), the 'date' tag holds "the date in which a release was made available through some sort of distribution mechanism". Relevant excerpts from the [id3v2.4 spec](http://id3.org/id3v2.4.0-frames): -'TDRC': "Recording time [...] when the audio was recorded". -'TDRL': "Release time [...] when the audio was first released" -'TDOR': "Original release time [...] when the original recording of the audio was released" Currently the 'date' tag is mapped to 'TDRC' (recording time). This commit changes the mapping to 'TDRL' (release time) to bring the two tag types more in line with each other.
|
It is kept as TDRC for program compatibility reasons.
The same goes for the rest of tagging programs. |
|
Two things:
If 1., then certainly, +100 from me. Edit: Ah, I see @samj1912 is faster than me. 👍 |
|
I seem to remember asking this myself a few years ago. I guess we need a comment in the code to point these things out. |
|
I submitted an issue (well, question) to mutagen asking about this behavior as well: quodlibet/mutagen#290 . If it turns out that it's something that should be fixed, I'll fix up this PR, otherwise, I'll close it. |
|
Looking at the reply by @lazka on quodlibet/mutagen#290 I think we can close this. |
According to the date docs, the 'date' tag holds "the date in which a release was made available through some sort of distribution mechanism".
Relevant excerpts from the id3v2.4 spec:
TDRC: "Recording time [...] when the audio was recorded".TDRL: "Release time [...] when the audio was first released"TDOR: "Original release time [...] when the original recording of the audio was released"Currently the 'date' tag is mapped to
TDRC(recording time). This commit changes the mapping toTDRL(release time) to bring the two tag types more in line with each other.