Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: crystal-lang/crystal
base: 9d3fd51f850d
Choose a base ref
...
head repository: crystal-lang/crystal
compare: dcf47e8ad8f2
Choose a head ref
  • 3 commits
  • 2 files changed
  • 1 contributor

Commits on Feb 10, 2017

  1. Fix: close IO on OpenSSL accept failure 

    This avoids leaving a socket in an indeterminate state opened longer
than necessary.

fixes #3953
    @ysbaddaden
    ysbaddaden authored and Santiago Palladino committed Feb 10, 2017
    Copy the full SHA
    18d3b6f View commit details
    Browse the repository at this point in the history

  2. Fix: HTTP server raises when TLS socket is normally closed 

    HTTP::Server defaults to a keepalive connection (as expected by the
spec), but the connection may be closed normally while HTTP::Request
is waiting to receive a new request to process, yet
`OpenSSL::SSL::Socket#read` raised an exception instead of returning
`0` to report an EOF.
    @ysbaddaden
    ysbaddaden authored and Santiago Palladino committed Feb 10, 2017
    Copy the full SHA
    e5273bd View commit details
    Browse the repository at this point in the history

  3. Fix: buffered IO won't close if flushing failed 

    IO::Buffered tries to flush pending data when it's closed, but if
flushing fails, it won't try to close the IO, which could lead to
leaking file descriptors.
    @ysbaddaden
    ysbaddaden authored and Santiago Palladino committed Feb 10, 2017
    Copy the full SHA
    dcf47e8 View commit details
    Browse the repository at this point in the history