upstart: wrap binaries and patch hard-coded paths #22410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@adnelson, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edolstra, @robberer and @MarcWeber to be potential reviewers. |
|
I'm somewhat surprised we still have upstart in Nixpkgs. IMHO, since we're no longer using it, it might be better to remove it altogether. |
|
I don't suppose it hurts to keep |
|
Well, this adds a non-trivial amount of code for a package that we don't maintain anymore. So I'm not super enthusiastic... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
I wanted to be able to use
init-checkconfto validate upstart config files during a nix build. Unfortunately, theinit-checkconfbinary wasn't usable due toPATHissues, hard-coded binary paths, and not having executable permissions. A few patches got things working though. In addition,init-checkconfrequires a dbus session to be available; I adapted a script which makes this possible into a nix expression.Unfortunately, since I'm not actually running upstart, it's pretty much impossible for me to actually check that all binaries work. However, since the only changes are to auxiliary scripts, I think this is pretty safe.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)