Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ecopcr: init at version 0.7.0 #22409

Closed
wants to merge 1 commit into from
Closed

ecopcr: init at version 0.7.0 #22409

wants to merge 1 commit into from

Conversation

metabar
Copy link

@metabar metabar commented Feb 3, 2017

Motivation for this change

This is a new package, ecoPCR, a bioinformatics tool to perform electronic PCR, developed by the Laboratoire d'Ecologie Alpine in Grenoble, France.
Ficetola, G.F., Coissac, E., Zundel, S., Riaz, T., Shehzad, W., Bessière, J., Taberlet, P. and Pompanon, F., 2010. An in silico approach for the evaluation of DNA barcodes. BMC genomics, 11(1), p.434.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@metabar, thanks for your PR! By analyzing the history of the files in this pull request, we identified @zraexy, @zimbatm and @peti to be potential reviewers.

rycee added a commit to rycee/nixpkgs that referenced this pull request Feb 3, 2017
@rycee
Suggested improvements for PR NixOS#22409
eead7cb
@rycee rycee mentioned this pull request Feb 3, 2017
Merged
@rycee
Copy link
Member

rycee commented Feb 3, 2017

Thanks for the pull request! At the moment the package is a bit more complicated than I think it needs to be. Please see the PR I submitted in your clone. If anything is unclear you should feel free to ask.

@rycee
Copy link
Member

rycee commented Feb 3, 2017

Also, before merging into master all the commits should be squashed into one commit having the commit message "ecopcr: init at 0.7.0".

@metabar
Copy link
Author

metabar commented Feb 6, 2017

Thanks for the review! The nix expression was edited with the suggested changes and more, the commits were squashed, and the package version is now 0.8.0. Everything is on https://github.com/metabarcoding/nixpkgs/tree/ecopcr. Should I open a new pull request?

@rycee
Copy link
Member

rycee commented Feb 6, 2017

Looking good! I rebased this into master in commit 78c052e. I made two changes in the commit:

  • I added python27 as a build input, needed by the Python script.

  • I changed the name field to name = "ecopcr-0.8.0", to match the tarball name and generally lowercase package names are preferred.

Many thanks for your contribution!

@rycee rycee closed this Feb 6, 2017
@metabar metabar deleted the ecopcr branch February 6, 2017 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@metabar @mention-bot @rycee @Janik-Haag