Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

postgrest: dontCheck #22407

Closed
wants to merge 1 commit into from
Closed

postgrest: dontCheck #22407

wants to merge 1 commit into from

Conversation

tomberek
Copy link
Contributor

@tomberek tomberek commented Feb 3, 2017

Motivation for this change

Function on darwin.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

This was referenced Feb 3, 2017
Closed
Closed
@LnL7 LnL7 added the 6.topic: darwin Running or building packages on Darwin label Feb 3, 2017
LnL7
LnL7 reviewed Feb 3, 2017
View reviewed changes
Copy link
Member

@LnL7 LnL7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably be conditional for darwin only, why does this fail?

@tomberek
Copy link
Contributor Author

tomberek commented Feb 4, 2017

@LnL7

haddock: internal error: spliceURL UnhelpfulSpan
CallStack (from HasCallStack):
  error, called at utils/haddock/haddock-api/src/Haddock/Backends/Xhtml/Utils.hs:79:9in main:Haddock.Backends.Xhtml.Utils
builder for ‘/nix/store/w18c5p4ijp3s6j14sfh08k21kq2gh1sv-swagger2-2.1.3.drv’ failed with exit code 1
cannot build derivation ‘/nix/store/drgphpf5c8la2c34w3h1f0xaf0w38ypv-postgrest-0.4.0.0.drv’: 1 dependencies couldn't be built
error: build of ‘/nix/store/drgphpf5c8la2c34w3h1f0xaf0w38ypv-postgrest-0.4.0.0.drv’ failed

@PierreR
Copy link
Contributor

PierreR commented Feb 4, 2017 •
edited

@tomberek Are you certain you are using the latest master branch from nixpkgs ? The haddock issue should already be fixed in the master branch thanks to the dontHaddock wrapper.

I have also made a PR to re-enable swagger2 hydra build. So in the next couple of days, we will know for sure if this is a darwin specific issue.

As an extra note, this haddock issue is fixed in ghc-8.0.2 which will be the default 8.0.x compiler soonish (as soon as the LTS-8 is out)

@LnL7
Copy link
Member

LnL7 commented Feb 4, 2017

I would be surprised if that's a darwin only issue.

@PierreR
Copy link
Contributor

PierreR commented Feb 10, 2017

swagger2 is building fine on hydra with linux or darwin: http://hydra.nixos.org/job/nixpkgs/trunk/haskellPackages.swagger2.x86_64-darwin

@tomberek This PR should be closed.

@fpletz fpletz closed this Feb 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LnL7 LnL7 LnL7 left review comments

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tomberek @PierreR @LnL7 @fpletz