-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dbus: don't search for units in current-system #22354
Conversation
Is this really a mass rebuild? I guess it'll mostly affect a bunch of linux-specific stuff |
Hm, I thought that systemd depends on dbus (don't judge me, I wouldn't be surprised if it depends on gtk :D) but it seems to be false. Still, it affects GTK and Qt at least -- I usually classified this as a mass rebuild. |
Hi abbradar,
Wat was the purpose of the removed |
@layus If I interpreted it properly it meant that without this flag an extra dependency (presumably between multiple outputs as it was added as part of that work) was created. I assumed that it was from
|
I think the same; the dependency isn't created now. Still, I wonder if some code in nixpkgs is relying on |
@vcunat There is I think, and |
Then what is the point of the services.dbus.packages option ? |
@layus To avoid installing to environment everything that installs a dbus service. IMHO we want most if not all system services to be installed like that, but this directory was added historically. |
At the end of the day, It adds confusion to search both services.dbus.packages and config.system.path. If we have services.dbus.packages, why even look into config.system.path ? You may want a package in the system path and another in dbus config. |
I agree but it may be very difficult to get rid of this (unknown number of modules depend on this) and this will break users configuration (off the top of my head -- |
agreed, indeed. Until someone complains :-). |
See #22353 -- with this OBEX and even networking finally works for me out of the box. |
This worked okay in a VM so let's merge this in few days. |
It seems that this is not the end of the story, but at least it helped to uncover an old bug :D Currently it manifests itself as inability to start services as The first strategy that comes to mind is to set |
Motivation for this change
Continuation of #22343. With this dbus always follows configuration files properly regardless of environment: upstream configuration -> NixOS's
-local.conf
-> other services and cofngiurations, including system path.Things done
(nix.useSandbox on NixOS,
or option
build-use-sandbox
innix.conf
on non-NixOS)
nix-shell -p nox --run "nox-review wip"
./result/bin/
)Tested in a VM together with #22343 and with strace to confirm that dbus reads all configuration files like before. cc @layus