afio: init at 2.5.1 #22812
Merged
afio: init at 2.5.1 #22812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Philipp Gesang <phg@phi-gamma.net>
joachifm
requested changes
Feb 19, 2017
|
|
||
| stdenv.mkDerivation rec { | ||
| version = "2.5.1"; | ||
| name = "afio"; |
There was a problem hiding this comment.
The version needs to be a part of name, as in name = "afio-${version}"; the attribute itself currently holds no special meaning.
| @@ -0,0 +1,33 @@ | |||
| --- p1/Makefile.orig 2017-02-14 21:40:20.404249126 +0100 | |||
There was a problem hiding this comment.
Is this your patch (i.e., no external source)?
|
2017-02-18 (Saturday), notifications@github.com (Joachim F.):
joachifm requested changes on this pull request.
Thanks for the feedback.
> @@ -0,0 +1,27 @@
+{ stdenv, fetchurl } :
+
+stdenv.mkDerivation rec {
+ version = "2.5.1";
+ name = "afio";
The version needs to be a part of `name`, as in `name = "afio-${version}"`; the attribute itself currently holds no special meaning.
Fixed, see the revised version.
> @@ -0,0 +1,33 @@
+--- p1/Makefile.orig 2017-02-14 21:40:20.404249126 +0100
Is this your patch (i.e., no external source)?
It is.
|
What revision version? Did you forget to push? |
|
2017-02-21 (Tuesday), notifications@github.com (Franz Pletz):
> Fixed, see the revised version.
What revision version? Did you forget to push?
Good question. I pushed after rebasing onto the then current
nixpkgs master. The commit is there:
phi-gamma@b4e9bcf
I just killed the branch and replaced it with my local head so
please check again.
|
joachifm
approved these changes
Feb 22, 2017
|
2017-02-22 (Wednesday), notifications@github.com (Joachim F.):
Merged #22812.
Great, thanks!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Philipp Gesang phg@phi-gamma.net
Motivation for this change
Add useful package.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)