Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iputils: 20151218 -> 20161105 #22822

Merged
merged 3 commits into from Feb 21, 2017
Merged

iputils: 20151218 -> 20161105 #22822

merged 3 commits into from Feb 21, 2017

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Feb 15, 2017

Motivation for this change

after the upgrade of iputils from 20151218 to 20161105
functionality of ping6 and tracepath6 was merged into ping and tracepath.

Ping is now mostly a drop-in replacment for ping6, except that selecting a
specific interface is done by encoding it into the address (ex.: fe80::1%eth0)
rather then specifing it with the -I flag.

Test check list:

  • nixos/modules/tasks/network-interfaces.nix
  • nixos/tests/cjdns.nix
  • nixos/tests/containers-bridge.nix
  • nixos/tests/containers-extra_veth.nix
  • nixos/tests/containers-ipv6.nix
  • nixos/tests/ipv6.nix
  • nixos/tests/networking.nix
  • pkgs/servers/monitoring/nagios/plugins/official-2.x.nix
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@Mic92, thanks for your PR! By analyzing the history of the files in this pull request, we identified @viric, @fpletz and @wkennington to be potential reviewers.

most notable change is the removal of tracepath6 and ping6
@Mic92 Mic92 force-pushed the iputils branch 2 times, most recently from 2b8d836 to 43f0250 Compare February 15, 2017 10:27
@fpletz fpletz added this to the 17.03 milestone Feb 16, 2017
@fpletz
Copy link
Member

fpletz commented Feb 16, 2017

We should mention in the release notes that ping6 and tracepath6 are not available anymore. These are common tools in the Linux userland.

Also note that there are multiple references to ping6 in pkgs and nixos.

@globin
Copy link
Member

globin commented Feb 16, 2017

We might want to link {ping,tracepath}6 to {ping,tracepath} for the time being?

@Mic92
Copy link
Member Author

Mic92 commented Feb 16, 2017

@globin I thought about that, but this might be a bad idea as the flags are different. Commands might check for the existence of ping6/tracepath6 but break because of incompatible syntax. I would rather want to see command not found in which case the programs can be patched rather then subtle bugs.
Also when do we want to get rid of these symlinks? There would be no deprecation message.

@globin
Copy link
Member

globin commented Feb 16, 2017

Yes, right.

@Mic92
Copy link
Member Author

Mic92 commented Feb 16, 2017

Is there a convienient way to run all tests in nixos/tests/networking.nix @wkennington?
Currently I do something like:

nix-build nixos/release.nix -A tests.networking.networkd.bridge

reason: after the upgrade of iputils from 20151218 to 20161105
functionality of ping6 and tracepath6 was merged into ping and tracepath.

Ping is now mostly a drop-in replacment for ping6, except that selecting a
specific interface is done by encoding it into the address (ex.: fe80::1%eth0)
rather then specifing it with the `-I` flag.
with the <literal>-I</literal> flag, but by encoding the interface into the
address (<literal>ping fe80::1%eth0</literal>).
</para>
</listitem>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can somebody proof-read this?

<listitem>
<para>
Iputils are no longer provide ping6 and traceroute6. The functionality of
these tools were integrated respectively into ping and traceroute. To
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

were -> have been, respectively into ping and traceroute -> into ping and traceroute respectively

@@ -217,6 +217,18 @@ following incompatible changes:</para>
</para>
</listitem>

<listitem>
<para>
Iputils are no longer provide ping6 and traceroute6. The functionality of
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Iputils are no longer -> Iputils no longer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants