New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iputils: 20151218 -> 20161105 #22822
Conversation
@Mic92, thanks for your PR! By analyzing the history of the files in this pull request, we identified @viric, @fpletz and @wkennington to be potential reviewers. |
most notable change is the removal of tracepath6 and ping6
2b8d836
to
43f0250
Compare
We should mention in the release notes that ping6 and tracepath6 are not available anymore. These are common tools in the Linux userland. Also note that there are multiple references to ping6 in pkgs and nixos. |
We might want to link |
@globin I thought about that, but this might be a bad idea as the flags are different. Commands might check for the existence of ping6/tracepath6 but break because of incompatible syntax. I would rather want to see |
Yes, right. |
Is there a convienient way to run all tests in
|
reason: after the upgrade of iputils from 20151218 to 20161105 functionality of ping6 and tracepath6 was merged into ping and tracepath. Ping is now mostly a drop-in replacment for ping6, except that selecting a specific interface is done by encoding it into the address (ex.: fe80::1%eth0) rather then specifing it with the `-I` flag.
with the <literal>-I</literal> flag, but by encoding the interface into the | ||
address (<literal>ping fe80::1%eth0</literal>). | ||
</para> | ||
</listitem> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can somebody proof-read this?
<listitem> | ||
<para> | ||
Iputils are no longer provide ping6 and traceroute6. The functionality of | ||
these tools were integrated respectively into ping and traceroute. To |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
were -> have been, respectively into ping and traceroute -> into ping and traceroute respectively
@@ -217,6 +217,18 @@ following incompatible changes:</para> | |||
</para> | |||
</listitem> | |||
|
|||
<listitem> | |||
<para> | |||
Iputils are no longer provide ping6 and traceroute6. The functionality of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Iputils are no longer -> Iputils no longer
Motivation for this change
after the upgrade of iputils from 20151218 to 20161105
functionality of ping6 and tracepath6 was merged into ping and tracepath.
Ping is now mostly a drop-in replacment for ping6, except that selecting a
specific interface is done by encoding it into the address (ex.: fe80::1%eth0)
rather then specifing it with the
-I
flag.Test check list:
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandbox
innix.conf
on non-NixOS)
nix-shell -p nox --run "nox-review wip"
./result/bin/
)