Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wip: codelite: init at 10.0 #22816

Closed
wants to merge 1 commit into from
Closed

wip: codelite: init at 10.0 #22816

wants to merge 1 commit into from

Conversation

rardiol
Copy link
Contributor

@rardiol rardiol commented Feb 15, 2017 •
edited

Motivation for this change
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Fails mid compilation with :


[  8%] Building CXX object CodeLite/CMakeFiles/libcodelite.dir/clBitmap.cpp.o
In file included from /nix/store/9kh6hb2yvk8fqa24cwnrch7ach9crl1m-glib-2.50.2-dev/include/glib-2.0/glib/galloca.h:32:0,
                 from /nix/store/9kh6hb2yvk8fqa24cwnrch7ach9crl1m-glib-2.50.2-dev/include/glib-2.0/glib.h:30,
                 from /nix/store/9kh6hb2yvk8fqa24cwnrch7ach9crl1m-glib-2.50.2-dev/include/glib-2.0/gobject/gbinding.h:28,
                 from /nix/store/9kh6hb2yvk8fqa24cwnrch7ach9crl1m-glib-2.50.2-dev/include/glib-2.0/glib-object.h:23,
                 from /nix/store/9kh6hb2yvk8fqa24cwnrch7ach9crl1m-glib-2.50.2-dev/include/glib-2.0/gio/gioenums.h:28,
                 from /nix/store/9kh6hb2yvk8fqa24cwnrch7ach9crl1m-glib-2.50.2-dev/include/glib-2.0/gio/giotypes.h:28,
                 from /nix/store/9kh6hb2yvk8fqa24cwnrch7ach9crl1m-glib-2.50.2-dev/include/glib-2.0/gio/gio.h:26,
                 from /nix/store/a1ljglvb7yi6j5p1vav1b6i7prjmfcfi-gtk+-2.24.31-dev/include/gtk-2.0/gdk/gdkapplaunchcontext.h:30,
                 from /nix/store/a1ljglvb7yi6j5p1vav1b6i7prjmfcfi-gtk+-2.24.31-dev/include/gtk-2.0/gdk/gdk.h:32,
                 from /nix/store/a1ljglvb7yi6j5p1vav1b6i7prjmfcfi-gtk+-2.24.31-dev/include/gtk-2.0/gtk/gtk.h:32,
                 from /tmp/nix-build-codelite-10.0.drv-0/codelite-10.0-src/CodeLite/clBitmap.cpp:6:
/nix/store/9kh6hb2yvk8fqa24cwnrch7ach9crl1m-glib-2.50.2-dev/include/glib-2.0/glib/gtypes.h:32:24: fatal error: glibconfig.h: No such file or directory

I assume the issue has something to do with cmake/Modules/FindGLIB2.cmake. The missing file seems to be at ${glib.out}/lib/glib-2.0/include/ . Is the include folder actually supposed to be there?

edit: ok, it compiles and installs now. Didn't do much testing yet.

@rardiol
Copy link
Contributor Author

rardiol commented Feb 20, 2017

This seems to rely a lot on looking for binaries at /usr/bin/ and in some cases PATH for compilers and a variety of tools. Not sure if it's better to use a pseudo FHS so it can happily find /usr/bin/make or go through the code and use substituteInPlace to replace "usr/bin" with "${gnumake}/bin" for example. By the way, I think the code expects some executables to be in the same folder as another it found previously, so I think the code would need to be patched too.

@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 17, 2018

Closing as it is outdated by now (v12 is released).
@rardiol feel free to open a new PR if you still want to add codelite to nixpkgs.
( about the hardcoded path: you could still write one big patch and keep it in-tree along default.nix if there is too many occurrences )

@c0bw3b c0bw3b closed this Nov 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rardiol @c0bw3b @joachifm