Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R: 3.2.4 -> 3.3.2 #22817

Merged
merged 2 commits into from Feb 27, 2017
Merged

R: 3.2.4 -> 3.3.2 #22817

merged 2 commits into from Feb 27, 2017

Conversation

jbedo
Copy link
Contributor

@jbedo jbedo commented Feb 15, 2017

Motivation for this change

R 3.2 is quite old and a lot of commonly used packages are not available or obsolete. This updates R to the latest minor version and updates the CRAN and bioconductor packages.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@jbedo, thanks for your PR! By analyzing the history of the files in this pull request, we identified @abbradar, @jefdaj and @michelk to be potential reviewers.

@dtzWill
Copy link
Member

dtzWill commented Feb 23, 2017

Is it okay to update these and not the other package sets? Hopefully! :)

Unfortunately this fails the 'test-evaluation.nix' check, looks like default.nix needs to be updated as well. Not sure if that just means removing references to no-longer-existing packages or if there's more to it?

$ nix-build test-evaluation.nix --dry-run
error: attribute ‘BNSP’ missing, at /~~/pkgs/development/r-modules/default.nix:83:8
(use ‘--show-trace’ to show detailed location information)

@yamad
Copy link

yamad commented Feb 23, 2017

+1. Resolves issues with this older pull request #20704 .

The "--with-system*" configure flags are deprecated in 3.3.2, so it makes sense to remove them from the default.nix.

This builds a functioning R on my macOS 10.11.6 machine, although this update does not solve what seems to be a longer standing issue that no interactive graphical device (x11, quartz,...) is available in the macOS build.

@jbedo
Copy link
Contributor Author

jbedo commented Feb 24, 2017

Thanks guys for the feedback. I've removed the --with-system flags and fixed the errors found by test-evaluation.nix, including a naming clash between the R package "import" and the import keyword in nix (fixed in the generation script).

@domenkozar
Copy link
Member

Note that we branch-off 17.03 today, so let's test and merge this. @lukego can you test this work for you?

@lukego
Copy link
Contributor

lukego commented Feb 27, 2017

@domenkozar Trying to test now. Just at the moment running pkgs/development/r-modules$ nix-build test-evaluation.nix on commit 4c2d75f is hanging with hundreds/thousands of messages like:

...
download-from-binary-cache.pl: still waiting for ‘https://cache.nixos.org/w7vrygwn1z466bgrafsjvprkxbalg4bz.narinfo’ after 5 seconds...
download-from-binary-cache.pl: still waiting for ‘https://cache.nixos.org/yh6hz97k25cjcbks0g2yvx49ay6z23r8.narinfo’ after 5 seconds...
download-from-binary-cache.pl: still waiting for ‘https://cache.nixos.org/l760g144v984jbm3kinxhl44693x3rm6.narinfo’ after 5 seconds...
download-from-binary-cache.pl: still waiting for ‘https://cache.nixos.org/rrdzdk8ch21jvpfdxjngc9n49wgmxi4r.narinfo’ after 5 seconds...
download-from-binary-cache.pl: still waiting for ‘https://cache.nixos.org/s8yvbk11xg0mrj8k6gw8k8ig5q6ag1b7.narinfo’ after 5 seconds...
...

@domenkozar
Copy link
Member

@lukego Nix should get 404 for most of those links and fallback to source building after some seconds. Does it not?

@lukego
Copy link
Contributor

lukego commented Feb 27, 2017

@domenkozar No, on my NixOS machine (lugano-3.snabb.co) it seems to be hanging for minutes at least after printing those messages. I am trying on my OSX machine now instead.

@domenkozar
Copy link
Member

Try adding --option connect-timeout 5 to the cli args

@lukego
Copy link
Contributor

lukego commented Feb 27, 2017

@domenkozar No difference. Can Hydra test this instead somehow instead of depending on my private tests?

@domenkozar
Copy link
Member

Will do that after lunch

@vcunat
Copy link
Member

vcunat commented Feb 27, 2017

R builds OK for me, but I haven't tested it except for starting up the interpreter.

@lukego
Copy link
Contributor

lukego commented Feb 27, 2017

I am a relative R newbie. I have some software I have developed with Rstudio that I want to deploy with nix, but I don't know exactly what versions I depend on, and I am happy if nixpkgs just picks up the latest versions and then I make that work for me.

@domenkozar
Copy link
Member

http://hydra.nixos.org/jobset/nixpkgs/r-updates#tabs-evaluations is evaluating /cc @peti

@domenkozar
Copy link
Member

It's almost half way through and most of packages compile. We can fix those that don't in the next month :) Thanks!

@domenkozar domenkozar merged commit 4ccb553 into NixOS:master Feb 27, 2017
@domenkozar domenkozar mentioned this pull request Feb 27, 2017
7 tasks
@jbedo jbedo deleted the r branch February 27, 2017 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants