droopy: init at 20160830 #22499
Merged
droopy: init at 20160830 #22499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aszlig
requested changes
Feb 10, 2017
|
|
||
| phases = [ "unpackPhase" "installPhase" "fixupPhase" ]; | ||
|
|
||
| installPhase = '' |
There was a problem hiding this comment.
What about just:
install -vD -m 0644 man/droopy.1 "$out/share/man/man1/droopy.1"
install -vD droopy "$out/bin/droopy"It's much more concise and also doesn't copy files to the wrong directories (like the wrong dir for the manpage) and cause artifacts (like "$out/droopy").
|
|
||
| with lib; | ||
|
|
||
| buildPythonApplication rec { |
There was a problem hiding this comment.
stdenv.mkDerivation with wrapPython in nativeBuildInputs should be enough here as the package doesn't have a setup.py and it also doesn't have any dependencies other than the Python standard library.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
./result/bin/)