Compiling ipynb now looks for default jupyter configuration #2650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kwpolska
requested changes
Jan 30, 2017
| @@ -82,6 +82,7 @@ def _compile_string(self, nb_json): | |||
| if flag is None: | |||
| req_missing(['ipython[notebook]>=2.0.0'], 'build this site (compile ipynb)') | |||
| c = Config(self.site.config['IPYNB_CONFIG']) | |||
| c.update(get_default_jupyter_config()) | |||
There was a problem hiding this comment.
Do not create a one-off function in nikola.utils, instead put it in ipynb.py.
|
@knowsuchagency, could you please address the review comments? |
|
I followed up on the requested changes in #2688, thanks a lot for the fix @knowsuchagency :-) Closing this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For those, like me, who use the jupyter extensions, specifically python markdown, this makes it so Nikola will automatically look to see if users have edited the configuration files nbconvert normally looks at when compiling notebooks itself.
Thus if you have a markdown cell that jupyter normally converts to 2 from {{ 1 + 1 }} in your notebook, you'll see the former rather than the later.