yaft: init at 0.2.9 #22261
Closed
yaft: init at 0.2.9 #22261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rycee
reviewed
Jan 29, 2017
|
|
||
| meta = { | ||
| homepage = "https://github.com/uobikiemukot/yaft"; | ||
| description = "yet another framebuffer terminal"; |
There was a problem hiding this comment.
The "y" in "yet" should be capitalized.
|
Maybe you forgot to add an attribute in |
matthiasbeyer
force-pushed
the
add-yaft
branch
from
d36d551
to
4fe0210
Compare
|
Hmm, this didn't build very well for me. Well it built but never installed anything but a few empty directories. I changed the expression a little: diff --git a/pkgs/applications/misc/yaft/default.nix b/pkgs/applications/misc/yaft/default.nix
index a1708c6..9d717e0 100644
--- a/pkgs/applications/misc/yaft/default.nix
+++ b/pkgs/applications/misc/yaft/default.nix
@@ -1,4 +1,4 @@
-{ stdenv, fetchFromGitHub, pkgconfig, ncurses, readline }:
+{ stdenv, fetchFromGitHub, ncurses }:
stdenv.mkDerivation rec {
version = "0.2.9";
@@ -11,10 +11,9 @@ stdenv.mkDerivation rec {
sha256 = "0l1ig8wm545kpn4l7186rymny83jkahnjim290wsl7hsszfq1ckd";
};
- installPhase = ''
- mkdir -p $out/{bin,share/man}
- DESTDIR=$out PREFIX=$out/bin/ MANPREFIX=$out/share/man/
- '';
+ buildInputs = [ ncurses ];
+
+ installFlags = [ "PREFIX=$(out)" "MANPREFIX=$(out)/share/man/" ];
meta = {
homepage = "https://github.com/uobikiemukot/yaft";and with that it appears to build and install OK. |
matthiasbeyer
force-pushed
the
add-yaft
branch
from
4fe0210
to
5b72065
Compare
|
Would be way easier if you would have pushed a commit that I can cherry-pick. But well, fixed your suggestions. |
|
@matthiasbeyer, you don't seem to apply the patch. I have opened a PR with the fixes: matthiasbeyer#5. |
|
@rasendubi 10 hrs ago I was in bed sleeping, and I have a life besides my computer. But here you go! |
|
Squashed and rebased into master in commit 904bcb3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)