apache-httpd: Add 'extensions' config option for mediawiki #22236
Conversation
Baughn
changed the title
|
|
||
| buildPhase = | ||
| '' | ||
| for skin in $skins; do | ||
| cp -prvd $skin/* skins/ | ||
| done | ||
| for extension in $extensions; do | ||
| cp -prvd $extension/* extensions/ |
There was a problem hiding this comment.
Would it be better to have each extension in it's own store path and using symlinks here?
Also you don't need the /* if you are using -r.
There was a problem hiding this comment.
It might be better, but I'm not familiar with mediawiki and don't know for certain that it'd accept symlinks. It might try to write to them.
As to the /*, note that $extension isn't a single extension; it's a directory containing extensions, which need to be copied including the directory name. That works the same way as for $skin, but if I changed it -- including by using a per-extension derivation -- I'd then need to pass the name of the extension out-of-band somehow.
Which might be fine if we had a complete list of them, but we don't. Today the way to add extensions to MediaWiki in NixOS is for the user to download them and put them in a directory... and that's probably fine.
There was a problem hiding this comment.
I'm not familiar with mediawiki
Well I presume you are testing this somehow? So if you can try and see if it works. I don't see why it wouldn't unless mediawiki was doing something quite odd.
It might try to write to them.
This won't be allowed in either case as the nix store is mounted read only.
As to the /*, note that $extension isn't a single extension; it's a directory containing extensions. ...
Ah, I see. That's fine then.
Motivation for this change
Being able to add additional extensions.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)