firefox-bin: Add gpg verification to updater #22270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garbas
approved these changes
Jan 29, 2017
| , baseName ? "firefox" | ||
| , basePath ? "pkgs/applications/networking/browsers/firefox-bin" | ||
| , basePath ? "pkgs/applications/networking/browsers/firefox-bin" | ||
| , baseUrl ? "http://archive.mozilla.org/pub/firefox/releases/" | ||
| }: | ||
|
|
||
| let | ||
| version = (builtins.parseDrvName name).version; | ||
| isBeta = builtins.stringLength version + 1 == builtins.stringLength (builtins.replaceStrings ["b"] ["bb"] version); | ||
| in writeScript "update-${baseName}-bin" '' |
There was a problem hiding this comment.
could you please turn this writeScript which I created some time ago to normal mkDerivation so that nobody seems the horrible PATH trickery I had to do ;)
|
merging as it's an improvement on the status-quo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Turns out the sha's changed because of build2 vs build3:
http://ftp.mozilla.org/pub/firefox/candidates/51.0.1-candidates/build3/SHA512SUMS vs http://ftp.mozilla.org/pub/firefox/candidates/51.0.1-candidates/build2/SHA512SUMS
(thanks to jcristau on mozilla's IRC for answering my question on a weekend! :) )
Made this PR as a sanity-check in the future. Opinions?
cc @taku0 @garbas @ttuegel @joachifm
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)