Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

firefox-bin: Update sha512 hash #22248

Closed
wants to merge 1 commit into from
Closed

firefox-bin: Update sha512 hash #22248

wants to merge 1 commit into from

Conversation

taku0
Copy link
Contributor

@taku0 taku0 commented Jan 29, 2017

Motivation for this change

For some reason, SHA512 hashes are updated.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@joachifm
Copy link
Contributor

It'd be good to know a bit more than "changed for some reason" before merging this, imo.

@joachifm joachifm mentioned this pull request Jan 29, 2017
Merged
7 tasks
@grahamc
Copy link
Member

grahamc commented Jan 29, 2017

Researching.

@grahamc grahamc mentioned this pull request Jan 29, 2017
Merged
7 tasks
@grahamc
Copy link
Member

grahamc commented Jan 29, 2017

Merged the other one, thank you!

@grahamc grahamc closed this Jan 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@taku0 @joachifm @grahamc