Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rambox: 0.4.5 -> 0.5.3 #22251

Merged
merged 1 commit into from Jan 29, 2017
Merged

rambox: 0.4.5 -> 0.5.3 #22251

merged 1 commit into from Jan 29, 2017

Conversation

ghost
Copy link

@ghost ghost commented Jan 29, 2017

Motivation for this change

Replacement for #22168 because of https://github.com/saenzramiro/rambox/issues/622

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@gnidorah, thanks for your PR! By analyzing the history of the files in this pull request, we identified @NeQuissimus to be a potential reviewer.

@joachifm joachifm merged commit 9f9f983 into NixOS:master Jan 29, 2017
@ghost ghost deleted the rambox branch January 30, 2017 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants