usb-modeswitch: 2.2.1 -> 2.5.0 and nixos module #22264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 18, 2017 11:35
We were carrying v2.2.1 and not v2.3.0 due to the update only touching the version and not the sha256 sum.
Plus some minor cleanups.
peterhoeg
force-pushed
the
m/modeswitch
branch
from
57f82d2
to
73c42eb
Compare
|
@MarcWeber, any comments? |
fpletz
reviewed
Feb 21, 2017
nixos/modules/hardware/usb_wwan.nix
Outdated
|
|
||
| options = { | ||
|
|
||
| hardware.usb_wwan = { |
There was a problem hiding this comment.
The consensus is to use camelCase for nixos options instead of separators.
There was a problem hiding this comment.
Changed. camelCase abbreviations just look really ugly though...
peterhoeg
force-pushed
the
m/modeswitch
branch
from
73c42eb
to
e82b059
Compare
peterhoeg
force-pushed
the
m/modeswitch
branch
from
e82b059
to
0789a2a
Compare
fpletz
approved these changes
Feb 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
We were carrying v2.2.1 and not v2.3.0 due to the update only touching the version and not the sha256 sum.
Additionally, we add a nixos module for setting up udev to use the rules.
Unfortunately, I no longer have the hardware that made me write the module, so I cannot actually test if it works. I thought it would be better to get things into nixpkgs instead of lingering around here...
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)