Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tetex: mark as broken, migrate packages to texlive #22279

Closed
wants to merge 4 commits into from

Conversation

langston-barrett
Copy link
Contributor

Partial fix for #21770: migrate ne and enblend-enfuse to texlive.

Motivation for this change

tetex is unsupported, and the download links don't work anymore.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Copy link

@DerTim1 DerTim1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved on Nix @ubuntu 16.04

@langston-barrett
Copy link
Contributor Author

Looks like the tests are timing out on Linux and OSX.

@vcunat
Copy link
Member

vcunat commented Jan 30, 2017

The main remaining package is asciidoc. I think we shouldn't mark tetex broken before migrating that one.

@langston-barrett
Copy link
Contributor Author

@vcunat I'll try to migrate that, and if I'm unsuccessful, I'll remove the commit marking tetex as broken.

@langston-barrett
Copy link
Contributor Author

I acutally can't get asciidoc or a2x working with the latex backend as it is now (even when building asciidoc-full), so I'm not sure how to test my changes.

I get this error using asciidoc:

$ ./result/bin/asciidoc --backend=latex test.asciidoc 
asciidoc: WARNING: test.asciidoc: line 4: missing section: [source-filter-style]
asciidoc: FAILED: test.asciidoc: line 4: malformed section entry: template::[source-filter-style]

and this with a2x:

$ PATH=$PATH:$PWD/result/bin ./result/bin/a2x --backend=latex test.asciidoc
a2x: ERROR: missing latex backend

@DerTim1
Copy link

DerTim1 commented Jan 31, 2017

I think this isn't a problem with tetex to texlive.combined.schema-basic. Look at https://groups.google.com/forum/#!topic/asciidoc/uUJz3TkOhks
So maybe the best thing would be to drop latex-support or leave it as it is (with broken latex-backend).

@peterhoeg
Copy link
Member

There's a patch for asciidoc (haven't tested it) that supposedly fixes it:

https://code.google.com/archive/p/asciidoc/issues/26

@vcunat
Copy link
Member

vcunat commented Feb 11, 2017

Oh, I forgot, I'm sorry. Those two commits are in master now. asciidoc is the only one remaining now.

@langston-barrett
Copy link
Contributor Author

@vcunat Which two commits?

@vcunat
Copy link
Member

vcunat commented Feb 11, 2017

The ones for ne and enblend-enfuse from this PR. See b9d6a6c and its parent.

@langston-barrett
Copy link
Contributor Author

@vcunat Thanks!

@vcunat
Copy link
Member

vcunat commented Feb 11, 2017

:-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants