Better implementation of flag on death PR 64 #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
track the last held ID, and check and see if it's landed yet, if not it's probalby the flag they died with since the client tries to drop them fast.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the client drops the flag before death, we can track the last used flag and see if it's landed yet, if not it was held a very short time before death and probably the one they were killed with.
This allows the API for flag on death to be created before 2.6.
Once the protocol is fixed, this will continue to work and the last held flag can be removed if it isn't needed by anything else.
@allejo should validate that this solves his issues.