flow: 0.37.1 -> 0.37.4 #22289
Merged
flow: 0.37.1 -> 0.37.4 #22289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@frontsideair, thanks for your PR! By analyzing the history of the files in this pull request, we identified @puffnfresh, @msteen and @despairblue to be potential reviewers. |
puffnfresh
approved these changes
Jan 30, 2017
|
Looks like 0.38.0 was released 12 days ago. Can we upgrade to that? |
|
I mentioned that in my PR but it was lost within the template I guess. :) I couldn't get it build on NixOS, I got an error saying: |
|
And yes, doesn't build on macOS. :( fsevents, my bane. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
New upstream release
Note: The latest version is 0.38.0 but it didn't build on my NixOS instance. Assuming upstream problem, will open an issue there.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)