Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python*Packages.pytest: defaults to pytest_30 #22280

Merged
merged 2 commits into from Jan 31, 2017
Merged

python*Packages.pytest: defaults to pytest_30 #22280

merged 2 commits into from Jan 31, 2017

Conversation

lsix
Copy link
Member

@lsix lsix commented Jan 29, 2017 •
edited

This commit is a no-op. All derivations that depended on pytest_29 as
pytest now depend on it explicitely.

The next step will be to check which derivation can use pytest_30 instead of pytest_29, but this can be done when updating the derivations.

cc @FRidh

Motivation for this change
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@lsix, thanks for your PR! By analyzing the history of the files in this pull request, we identified @matthiasbeyer, @garbas, @spwhitt and @FRidh to be potential reviewers.

RonnyPfannschmidt
RonnyPfannschmidt reviewed Jan 30, 2017
View reviewed changes
pkgs/tools/text/mir-qualia/default.nix
@@ -3,7 +3,7 @@
pythonPackages.buildPythonApplication rec {
name = "mir.qualia-${version}";
version = "1.0.0";
doCheck = false; # 1.0.0-released pytests are broken
doCheck = false; # 1.0.0-released pytests_29 are broken
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks like a mistake changing the comment instead of the dep

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, thanks for spotting it! It is fixed and pushed again.

@FRidh
Copy link
Member

FRidh commented Jan 30, 2017

@lsix, if you want to test this, then I recommend just switching to python 3.0, and push to python-wip branch. A job is created at https://headcounter.org/hydra/jobset/iElectric/python-wip. You can then see which packages fail with 3.0 and set those to 2.9.

@FRidh
Copy link
Member

FRidh commented Jan 30, 2017 •
edited

Or, since PR's are now build, you could check https://prs.nix.gsc.io/project/nixos
I recommend you rebase against nixpkgs-unstable to minimize the rebuilding.

@matthiasbeyer
Copy link
Contributor

@FRidh PRs are build by hydra?

@lsix
Copy link
Member Author

lsix commented Jan 30, 2017

@matthiasbeyer yes, and this is quite new and have been brought to us by @grahamc (A big thanks to him for that). You can see the mail about that on nix-dev here: http://lists.science.uu.nl/pipermail/nix-dev/2017-January/022621.html.

@FRidh since I can rely on hydra to check what migrating to pytest-3 breaks, I’ll do that. I mark this PR as WIP and get to work !

@lsix lsix changed the title python*Packages.pytest: defaults to pytest_30 [WIP] python*Packages.pytest: defaults to pytest_30 Jan 30, 2017
@FRidh
Copy link
Member

FRidh commented Jan 30, 2017

@lsix actually, I just realized that not all Python packages are build by the jobset that instance uses. So, for testing all Python packages I recommend you still use the python-wip branch.

@lsix
Copy link
Member Author

lsix commented Jan 30, 2017

@FRidh I have pushed ef5f376 (branched of nixos-unstable from the nixpkgs-channels repo) to python-wip. I’ll have a look tomorrow to see the status of the hydra build.

@grahamc
Copy link
Member

grahamc commented Jan 31, 2017

not all Python packages are build by the jobset that instance uses

is this because I use the nixpkgs expression, not the nixos one? I'd be happy to change this.

@lsix
Copy link
Member Author

lsix commented Jan 31, 2017

@FRidh according to https://headcounter.org/hydra/eval/347928?compare=-86400 I should be good with this version of the PR.

@lsix lsix changed the title [WIP] python*Packages.pytest: defaults to pytest_30 python*Packages.pytest: defaults to pytest_30 Jan 31, 2017
@FRidh FRidh merged commit 18ac28b into NixOS:master Jan 31, 2017
@FRidh
Copy link
Member

FRidh commented Jan 31, 2017

great, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RonnyPfannschmidt RonnyPfannschmidt RonnyPfannschmidt left review comments

Assignees
No one assigned
Labels
6.topic: python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@lsix @mention-bot @FRidh @matthiasbeyer @grahamc @RonnyPfannschmidt