Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ghostscript: fix installed library name on darwin #22875

Merged
merged 1 commit into from Feb 16, 2017

Conversation

acowley
Copy link
Contributor

@acowley acowley commented Feb 16, 2017

Motivation for this change

This was one of the things breaking octaveFull for me on darwin.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@acowley, thanks for your PR! By analyzing the history of the files in this pull request, we identified @abbradar, @vcunat and @edolstra to be potential reviewers.

@vcunat
Copy link
Member

vcunat commented Feb 16, 2017

Doesn't this interact with the preFixup phase somehow?

@acowley
Copy link
Contributor Author

acowley commented Feb 16, 2017

It doesn't seem to:

$ cd $(nix-build --no-out-link '<nixpkgs>' -A ghostscript)
$ otool -L bin/gs
bin/gs:
	/nix/store/7pr4ir0cb0k5k0v1fb8lpx0zalsrcb4x-ghostscript-9.20/lib/libgs.dylib.9.20 (compatibility version 0.0.0, current version 0.0.0)
	/nix/store/6f6kw88dcq5cfl2dhzs9cyvkpp9vl2i9-Libsystem-osx-10.11.6/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1226.10.1)

My understanding is that the preFixup is making up for linking the library in the build directory, and at that point the lib doesn't have its own name fixed up.

@LnL7 LnL7 added the 6.topic: darwin Running or building packages on Darwin label Feb 16, 2017
Copy link
Member

@LnL7 LnL7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason why you added this to the postInstall instead of fixup?

@acowley
Copy link
Contributor Author

acowley commented Feb 16, 2017

I copied the approach used in zlib. It's also done in postInstall in various places in llvm. That said, it's done in installPhase in other packages, so there's no unanimous idiom.

@LnL7 LnL7 merged commit 2fe4050 into NixOS:master Feb 16, 2017
@acowley acowley deleted the ghostscript-id branch October 9, 2017 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: darwin Running or building packages on Darwin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants