Skip to content

Commit

Permalink
libxml2: bugfix updates from git upstream
Browse files Browse the repository at this point in the history
This should solve CVE-2016-5131 and some other bugs, but not what Suse
calls CVE-2016-9597: https://bugzilla.suse.com/show_bug.cgi?id=1017497
The bugzilla discussion seems to indicate that the CVE is referenced
incorrectly and only shows reproducing when using command-line flags
that are considered "unsafe".

CVE-2016-9318 also remains unfixed, as I consider their reasoning OK:
https://lwn.net/Alerts/714411/

/cc #22826.
  • Loading branch information
vcunat committed Feb 16, 2017
1 parent 524de86 commit 5ad81ab
Showing 1 changed file with 4 additions and 10 deletions.
14 changes: 4 additions & 10 deletions pkgs/development/libraries/libxml2/default.nix
Expand Up @@ -17,19 +17,13 @@ in stdenv.mkDerivation rec {

patches = [
(fetchpatch {
name = "CVE-2016-4658.patch";
url = "https://git.gnome.org/browse/libxml2/patch/?id=c1d1f7121194036608bf555f08d3062a36fd344b";
sha256 = "0q7i5qgwgzp2x4r820mqq3nx69bgkd7n0v00j28wa6hndbfaaxmb";
# Contains fixes for CVE-2016-{4658,5131} and other bugs.
name = "misc.patch";
url = "https://git.gnome.org/browse/libxml2/patch/?id=e905f081&id2=v2.9.4";
sha256 = "14rnzilspmh92bcpwbd6kqikj36gx78al42ilgpqgl1609krb5m5";
})
];

# https://bugzilla.gnome.org/show_bug.cgi?id=766834#c5
postPatch = "patch -R < " + fetchpatch {
name = "schemas-validity.patch";
url = "https://git.gnome.org/browse/libxml2/patch/?id=f6599c5164";
sha256 = "0i7a0nhxwkxx6dkm8917qn0bsfn1av6ghg2f4dxanxi4bn4b1jjn";
};

outputs = [ "bin" "dev" "out" "doc" ]
++ lib.optional pythonSupport "py";
propagatedBuildOutputs = "out bin" + lib.optionalString pythonSupport " py";
Expand Down

2 comments on commit 5ad81ab

@grahamc
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be applied to 16.09 as well?

@vcunat
Copy link
Member Author

@vcunat vcunat commented on 5ad81ab Feb 18, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, and you did so: 1cc9887. I was originally waiting for rebuild to finish on staging to get more confidence it won't break anything.

Please sign in to comment.