Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various python #22873

Merged
merged 4 commits into from Apr 1, 2017
Merged

Various python #22873

merged 4 commits into from Apr 1, 2017

Conversation

teh
Copy link
Contributor

@teh teh commented Feb 16, 2017 •
edited

Motivation for this change

Don't merge just yet, running nox-review fails locally so I want to try the pr option.

error: while querying the derivation named ‘tex4ht-1.0.2009_06_11_1038’:
while evaluating the attribute ‘buildPhase’ of the derivation ‘tex4ht-1.0.2009_06_11_1038’ at /home/tom/.nox/nixpkgs/pkgs/tools/typesetting/tex/tex4ht/default.nix:4:3:
cannot coerce null to a string, at /home/tom/.nox/nixpkgs/pkgs/tools/typesetting/tex/tex4ht/default.nix:15:16
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@teh
Copy link
Contributor Author

teh commented Feb 16, 2017

Still no luck, not sure what's up, could be related to 2aff29c by @vcunat ?

In any case, I build by hand:

nix-build -A pythonPackages.tables
nix-build -A pythonPackages.Logbook
nix-build -A python3Packages.tables
nix-build -A python3Packages.Logbook

and everything succeeded

@teh teh changed the title WIP: Various python Various python Feb 16, 2017
vcunat added a commit that referenced this pull request Feb 16, 2017
@vcunat
tex4ht: fixup evaluation errors in the broken package
03024b3 
#22873 (comment)
@vcunat
Copy link
Member

vcunat commented Feb 16, 2017

Ah, yes. It should be OK now. Some things don't behave very smart, unfortunately.

@teh
Copy link
Contributor Author

teh commented Feb 17, 2017

I get some bizarre errors for rpy2 when building on debian [1] but on nixos nox-review pr 22873 now succeeds after fixing unrelated failures in vega and altair.

Can't wait for PR testing by Hydra!

[1] - linking again the local readline .. bizarre, but rpy2 does a lot of weird stuff anyway due to R being weird.

ldd /nix/store/dsg3kdf3z1gc4ycdk74b11s51svywix9-python2.7-rpy2-2.8.2/lib/python2.7/site-packages/rpy2/rinterface/_rinterface.so  | grep /lib/x
	libreadline.so.6 => /lib/x86_64-linux-gnu/libreadline.so.6 (0x00007f21a820f000)
	libtinfo.so.5 => /lib/x86_64-linux-gnu/libtinfo.so.5 (0x00007f21a37cc000)

@vcunat
Copy link
Member

vcunat commented Feb 17, 2017

You would avoid most of these problems by using nix's sandboxing – that way the builders won't see any /usr/ or /lib/.

@teh
Copy link
Contributor Author

teh commented Feb 17, 2017

@vcunat - thanks. My laptop runs a single-user nix packages on debian which is a slightly unusual arrangement. I'm not sure that's worth blocking on.

FRidh
FRidh reviewed Feb 18, 2017
View reviewed changes
pkgs/top-level/python-packages.nix Outdated

# Tests try to execute notebooks that aren't tests:
# TypeError: calling <function tutorial at 0x7fffe1bb8048> returned None, not a test
doCheck = false;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe the test runner should be invoked differently?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

figured it out, needs a UTF locale as well, hope this translates to hydra (works locally).

@FRidh
Copy link
Member

FRidh commented Mar 15, 2017

@teh Could you rebase and update this PR?

teh added 3 commits March 15, 2017 12:28
@teh
Logbook: 0.11.3 -> 1.0.0
b0115c2
@teh
pytables: 3.2.2 -> 3.3.0
5e31a7c
@teh
vega: add pytest as a build-input.
90223a9 
It's unclear how this worked before but it clearly did because we
have vega running in production.
@teh
altair: 1.0.0 -> 1.2.0
5a9e14e 
Also disabling tests because the test runner picks up too much and
then fails.
@teh
Copy link
Contributor Author

teh commented Mar 15, 2017

rebased, PTAL

@vcunat
Copy link
Member

vcunat commented Apr 1, 2017

I see python3Packages.altair fails tests, but it was so before this PR as well...

@vcunat vcunat merged commit 5a9e14e into NixOS:master Apr 1, 2017
vcunat added a commit that referenced this pull request Apr 1, 2017
@vcunat
Merge #22873: updates of various python packages
40628d9
@teh teh deleted the various-python branch April 2, 2017 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh FRidh approved these changes

Assignees
No one assigned
Labels
6.topic: python 8.has: package (update)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@teh @vcunat @FRidh