MBS-9237: Fix complex artist credit detection #468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwiencek
reviewed
Feb 16, 2017
| @@ -37,7 +37,7 @@ const reduceArtistCredit = ac => ac.names.reduce(reduceName, ''); | |||
| const isComplexArtistCredit = function (ac) { | |||
| const firstName = ac.names.get(0); | |||
| if (firstName && hasArtist(firstName)) { | |||
| return firstName.artist.name !== reduceArtistCredit(ac); | |||
| return firstName.artist.name !== reduceArtistCredit(ac) || !nonEmpty(firstName.name); | |||
There was a problem hiding this comment.
Yeah, I think this makes sense. My only recommendation would be to take advantage of short-circuit evaluation and put the !nonEmpty(firstName.name) check before the first one, since reduceArtistCredit is more expensive.
|
Test failures look unrelated, despite being for ACs. Those are the same ones that happened in one of my PRs and then disappeared. |
Previously, empty Artist Credits were mistakenly considered as simple, so triggering the Artist field Autocomplete to fill back user emptied Artist Credit in the Artist Credit editor bubble. This is because empty artist credit is reduced to artist name. This patch fixes the isComplexArtistCredit to consider empty Artist Credit as complex. This prevents the automatic fill-back of Artist Credit field in the Artist Credit editor to mistakenly happen before the field looses focus. See `onNameBlur` for proper fill-back.
yvanzo
force-pushed
the
mbs-9237-ac-fill-back
branch
from
473fa3b
to
37dd594
Compare
|
One more request (sorry :)). We have tests for |
|
Thanks for spotting this. Done in 6606e35. |
yvanzo
force-pushed
the
mbs-9237-ac-fill-back
branch
3 times, most recently
from
8080cba
to
7ed9c28
Compare
Note: `artistCreditFromArray` can not be used since it replaces empty `name` by `artist.name`.
yvanzo
force-pushed
the
mbs-9237-ac-fill-back
branch
from
7ed9c28
to
6606e35
Compare
mwiencek
approved these changes
Feb 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix MBS-9237: Don't immediately fill back the default AC while editor is typing.
Previously, empty Artist Credits were mistakenly considered as simple, so triggering the Artist field Autocomplete to fill back user emptied Artist Credit in the Artist Credit editor bubble. This is because empty artist credit is reduced to artist name.
This patch fixes the
isComplexArtistCreditto consider empty Artist Credit as complex. This prevents the automatic fill-back of Artist Credit field in the Artist Credit editor to mistakenly happen before the field looses focus. SeeonNameBlurfor proper fill-back.