Avoid redundant builds of OSX with xcode7.3 #4043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xcode7.3 is now the default OS X version in TravisCI, so we're building the project twice with the same configuration See https://docs.travis-ci.com/user/osx-ci-environment/#OS-X-Version
|
How useful has building on both xcode versions been? Has it caught any bugs? Would be useful to know for #3721. |
|
(BTW, from the docs, we're redundantly building twice with xcode7.3 for 5 months) |
|
@RX14 i don't recall any bug catched. I think it's fine to merge this and later increase the matrix if needed. I do think we should support older macs though. |
|
I restarted the hung OSX job on Travis. |
|
Merging, as nothing broke |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xcode7.3 is now the default OS X version in TravisCI, so we're building the project twice with the same configuration.
The second build was added in #2595, when xcode6.1 was the default. It doesn't make sense anymore.
I'm currently working on the project's build matrix for a long-term solution - I'll probably explicitly state each OSX version -, but this should speed builds up in the mean time.
https://docs.travis-ci.com/user/osx-ci-environment/#OS-X-Version now says: