Don't use Post.source_path directly to determine translated post's source file name. #2669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…urce file name. Allowing Post.translated_source_path() to return None.
Kwpolska
reviewed
Feb 16, 2017
| source_lang = utils.get_translation_candidate(self.site.config, source, lang) | ||
| if os.path.exists(source_lang): | ||
| source = source_lang | ||
| if os.path.isfile(source): |
There was a problem hiding this comment.
Why was all this code removed? Was it all redundant?
There was a problem hiding this comment.
This code essentially does what post.translated_source_path(lang) is supposed to be doing. Even worse, it uses a slightly different logic, which could cause incorrect source files to be copied.
Kwpolska
approved these changes
Feb 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allowing Post.translated_source_path() to return None.
Helping with one aspect of #2659.